php mail script not sending email

[bandos-scape12]

I am making a feedback page for my website. The script is as follows.

<?php
/*
This first bit sets the email address that you want the form to be submitted to.
You will need to change this value to a valid email address that you can access.
*/
$webmaster_email = "updates@teamodyssey.x10.mx";

/*
This bit sets the URLs of the supporting pages.
If you change the names of any of the pages, you will need to change the values here.
*/
$feedback_page = "feedback_form.html";
$error_page = "error_message.html";
$thankyou_page = "thank_you.html";

/*
This next bit loads the form field data into variables.
If you add a form field, you will need to add it here.
*/
$email_address = $_REQUEST['email_address'] ;
$comments = $_REQUEST['comments'] ;

/*
The following function checks for email injection.
Specifically, it checks for carriage returns - typically used by spammers to inject a CC list.
*/
function isInjected($str) {
	$injections = array('(\n+)',
	'(\r+)',
	'(\t+)',
	'(%0A+)',
	'(%0D+)',
	'(%08+)',
	'(%09+)'
	);
	$inject = join('|', $injections);
	$inject = "/$inject/i";
	if(preg_match($inject,$str)) {
		return true;
	}
	else {
		return false;
	}
}

// If the user tries to access this script directly, redirect them to the feedback form,
if (!isset($_REQUEST['email_address'])) {
header( "Location: $feedback_page" );
}

// If the form fields are empty, redirect to the error page.
elseif (empty($email_address) || empty($comments)) {
header( "Location: $error_page" );
}

// If email injection is detected, redirect to the error page.
elseif ( isInjected($email_address) ) {
header( "Location: $error_page" );
}

// If we passed all previous tests, send the email then redirect to the thank you page.
else {
mail( "$webmaster_email", "Feedback Form Results",
  $comments, "From: $email_address" );
header( "Location: $thankyou_page" );
}
?>

The html code is as follows.

<h1>Send Us Your Suggestion!</h1>
<form action="send_mail.php" method="post">
<table>
<tr>
<td>Email Address:</td>
<td>
<input type="text" name="email_address" value="" maxlength="100" />
</td>
</tr>
<TD><DIV align="right">
<FONT COLOR="FFFFFF"><B>DO NOT CHANGE --> Subject:</B></FONT>
</DIV>
</TD>
<TD><TEXTAREA name="Subject" cols="30" wrap="virtual" rows="1">
Song Suggestion</TEXTAREA>
</TD></TR>
<tr>
<td>Comments:</td>
<td>
<textarea rows="10" cols="50" name="comments"></textarea>
</td>
</tr>
<tr><td>&nbsp;</td>
<td>
<input type="submit" value="Submit" />
</td>
</tr>
</table>
</form>

The email is a webmail account setup on my x10 account. It is supposed to send an email with what the person typed into the comment box but i am not getting the email when i test it. I uploaded it to the site to see if it was just my computer not being capable to run the script but that didn't work either.

Any ideas on how to fix?

 

[creastery]

The script worked for me..but it took a long time before I actually received it. (11min+)
One thing to note is that you not only need to check if the message is injected, you also need to verify if the email is valid using this regex expression.

function verifyEmail($email) {
	return ( ! preg_match("/^([a-z0-9\+_\-]+)(\.[a-z0-9\+_\-]+)*@([a-z0-9\-]+\.)+[a-z]{2,6}$/ix", $str)) ? FALSE : TRUE;
}

Another thing you need to do is to use wordwrap to bring any line with more than 70 characters to the next line.
Here is how you do it:

$comments= wordwrap($comments, 70);

Refer to http://www.phpbuilder.com/board/showthread.php?t=10310187 if you are not sure why there is a need to bring any line with more than 70 characters to the next line.

This should solve most of your problems..anyway I just want to say this: You set an input field (subject) and you did not use it in any part of the mail. So remember to do something about it!