need help with a Make contact form and send email in PHP

[zynischen]

i need help it is not exactly working

<?
  if ($_POST["email"]<>'') {
$ToEmail = 'youremail@site.com';
$EmailSubject = 'Site contact form ';
$mailheader = "From: ".$_POST["email"]."\r\n";
$mailheader .= "Reply-To: ".$_POST["email"]."\r\n";
$mailheader .= "Content-type: text/html; charset=iso-8859-1\r\n";
$MESSAGE_BODY = "Name: ".$_POST["name"]."<br>";
$MESSAGE_BODY .=  "Email: ".$_POST["email"]."<br>";
$MESSAGE_BODY .=  "Comment: ".nl2br($_POST["comment"])."<br>";
mail($ToEmail, $EmailSubject, $MESSAGE_BODY, $mailheader) or die ("Failure");
?>
Your message was sent
<? } else { ?>
<form action="test.php" method="post">
<table width="400" border="0" cellspacing="2" cellpadding="0">
<tr>
<td width="29%" class="bodytext">Your name:</td>
<td width="71%"><input name="name" type="text" id="name" size="32"></td>
</tr>
<tr>
<td class="bodytext">Email address:</td>
<td><input name="email" type="text" id="email" size="32"></td>
</tr>
<tr>
<td class="bodytext">Comment:</td>
<td><textarea name="comment" cols="45" rows="6" id="comment" class="bodytext"></textarea></td>
</tr>
<tr>
<td class="bodytext">&nbsp;</td>
<td align="left" valign="top"><input type="submit" name="Submit" value="Send"></td>
</tr>
</table>
</form> 
<? }; ?>

so can anyone help or do it for me not to good with this stuff

 

[kajasweb]

- Change

if ($_POST["email"]<>'') {

To

if ($_POST['email'] != "") {

- Change " to ' used in Array Association Strings, i.e., $_POST["something"] to $_POST['something']

- Not a big one, but consider changing

<form action="test.php" method="post">

to

<form action="<?php print $_SERVER['PHP_SELF']; ?>" method="post">

 

[Slothie]

<?php
  if (!empty($_POST["email"])) {
	$ToEmail = 'youremail@site.com';
	$EmailSubject = 'Site contact form ';
	$mailheader = "From: ".$_POST["email"]."\r\n";
	$mailheader .= "Reply-To: ".$_POST["email"]."\r\n";
	$mailheader .= "Content-type: text/html; charset=iso-8859-1\r\n";
	$MESSAGE_BODY = "Name: ".$_POST["name"]."<br>";
	$MESSAGE_BODY .=  "Email: ".$_POST["email"]."<br>";
	$MESSAGE_BODY .=  "Comment: ".nl2br($_POST["comment"])."<br>";
	mail($ToEmail, $EmailSubject, $MESSAGE_BODY, $mailheader) or die ("Failure");
	?>
	Your message was sent
<?php } else { 	?>
	<form action="test.php" method="post">
	<table width="400" border="0" cellspacing="2" cellpadding="0">
	<tr>
	<td width="29%" class="bodytext">Your name:</td>
	<td width="71%"><input name="name" type="text" id="name" size="32"></td>
	</tr>
	<tr>
	<td class="bodytext">Email address:</td>
	<td><input name="email" type="text" id="email" size="32"></td>
	</tr>
	<tr>
	<td class="bodytext">Comment:</td>
	<td><textarea name="comment" cols="45" rows="6" id="comment" class="bodytext"></textarea></td>
	</tr>
	<tr>
	<td class="bodytext">&nbsp;
	</td>
	<td align="left" valign="top"><input type="submit" name="Submit" value="Send"></td>
	</tr>
	</table>
	</form> 
<?php }; ?>