Parse error: syntax error, unexpected T_ELSE

[whathappenswhen53]

Hi everyone,
I have a tiny problem that I need experienced help with.
I searched the net for hours but I couldn't find a solution to this problem.
so consider this as my last ditch effort for a solution.

I get this error message.

Parse error: syntax error, unexpected T_ELSE in /www/htdocs/login.php on line 26

Seems simple enough to solve.
However I checked the syntax through and through and no solution.

Here's my PHP coding:

<?php

$username = $_POST["username"];
$password = $_POST["password"];

if ($username&&$password)
{
    $connect = mysql_connect("localhost","username","password") or die ("Couldn't connect!");
    mysql_select_db("DB_name") or die ("Couldn't find DB");
    $query = mysql_query("SELECT * FROM users WHERE username='$username'");
    
$numrows = mysql_num_rows($query);
if ($numrows!=0)
{
    while ($row = mysql_fetch_assoc($query))
    {
        $dbusername = $row["username"];
        $dbpassword = $row["password"];
    }
    
    // check to see if they match!
    if ($username==$dbusername&&$password==$dbpassword);
    {
        echo "Your're in!";    
    }
    else
    echo "Wrong Password!";
}
else
die("That user doesn't exist!");


    }
else
die ("Please enter a username and a password!");
?>

Please, a solution to this problem will give you good karma :redface:.

 

[Livewire]

Line 22 is your problem:

    if ($username==$dbusername&&$password==$dbpassword);

Remove the ; - the ; is telling php that there actually isn't anything to do if the "if" condition matches. If you remove that it'll either start working, or give a different error for us to look at

 

[whathappenswhen53]

Wow Amazing!
Such a relief.
Thank you very much.

 

[misson]

There are other problems with your code you need to address.

$connect = mysql_connect("localhost","username","password") or die ("Couldn't connect!");
    mysql_select_db("DB_name") or die ("Couldn't find DB");

Don't use die if you're outputting HTML.

Don't use SELECT *; select only the columns you need.

<?php
$username = $_POST["username"];
$password = $_POST["password"];
[...]
    $query = mysql_query("SELECT * FROM users WHERE username='$username'");

This is vulnerable to SQL injection. The safest, easiest way of fixing this is to switch from the outdated mysql driver to PDO and make use of prepared statements. If you want a PDO tutorial, try "Writing MySQL Scripts with PHP and PDO".

    while ($row = mysql_fetch_assoc($query))

There should be at most one user with a given name, so there should be at most one row returned, so there's no need for a loop. To simplify this whole section, all you need to do is fetch a row from the query result without a loop. If you get FALSE, there were no matching rows; if you get a row, the username exists.

    // check to see if they match!
    if ($username==$dbusername&&$password==$dbpassword);

You don't need to check that $username==$dbusername, since the SQL statement ensures this will always be true when that particular if statement is executed.

Don't store plain text passwords, which is very insecure. Store salted, hashed passwords.

    echo "Wrong Password!";

Informing a visitor that the username is correct but the password is wrong may reveal too much information, as crackers must otherwise figure out both the username and password. On the other hand, username checkers are a common feature of registration forms, so if your site has this, you might as well have separate errors for an incorrect username and for a password.